Update keys_in_react.md: fix typo in line 82 #28549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentence "Using `key={Math.random()}` or `key={uuid()}` *while* rendering the list defeats the purpose of the list, ..." doesn't really make sense and maybe the intended was:
"Using `key={Math.random()}` or `key={uuid()}` *while* rendering the list defeats the purpose of the key, ..."
I checked with some collaborators on discord that seem to agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
The sentence "Using
key={Math.random()}orkey={uuid()}while rendering the list defeats the purpose of the list, ..." doesn't really make sense and maybe the intended was:"Using
key={Math.random()}orkey={uuid()}while rendering the list defeats the purpose of the key, ..."I checked with some collaborators on discord who seem to agree.
This PR
Change the word list for key in line 82
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection